Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 23 in Jenkinsfile #3005

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Use Java 23 in Jenkinsfile #3005

merged 1 commit into from
Sep 26, 2024

Conversation

mickaelistria
Copy link
Contributor

What it does

Updates Jenkinsfile to test against Java 23

How to test

Just let CI do the job.

Author checklist

@akurtakov
Copy link
Contributor

@iloveeclipse WDYT?

@iloveeclipse
Copy link
Member

I'm out of PC now, the tests are failing because of Java 23?

There are at least two issues known with Java 23, both affect JDT, @stephan-herrmann : WDYT?

@stephan-herrmann
Copy link
Contributor

I'm out of PC now, the tests are failing because of Java 23?

This PR failed at org.eclipse.jdt.core.tests.builder.BuildpathTests.testChangeZIPArchive1 which does not hint at a Java 23 issue.

There are at least two issues known with Java 23, both affect JDT, @stephan-herrmann : WDYT?

Which known issues are you referring to? The JIT bug, or the other JVM bug since 18 surfacing in JavaLeakTests? Or ...?

@stephan-herrmann
Copy link
Contributor

Generally I very much appreciate running builds / tests on Java 23.

@jukzi
Copy link
Contributor

jukzi commented Sep 26, 2024

CI succeeded with openjdk 21.0.2+13-58

[2024-09-25T14:34:46.349Z] + java -version
[2024-09-25T14:34:46.349Z] openjdk version "21.0.2" 2024-01-16
[2024-09-25T14:34:46.349Z] OpenJDK Runtime Environment (build 21.0.2+13-58)
[2024-09-25T14:34:46.349Z] OpenJDK 64-Bit Server VM (build 21.0.2+13-58, mixed mode, sharing)

@jukzi jukzi merged commit cb2ef5d into eclipse-jdt:master Sep 26, 2024
9 checks passed
@jukzi
Copy link
Contributor

jukzi commented Sep 26, 2024

21.0.2+13-58

oh, but you configured 23, why did it not run with 23? maybe permission missing for author. lets see what master does.

@jukzi
Copy link
Contributor

jukzi commented Sep 26, 2024

master runs now with 23+37-2369

11:22:23  + java -version
11:22:23  openjdk version "23" 2024-09-17
11:22:23  OpenJDK Runtime Environment (build 23+37-2369)
11:22:23  OpenJDK 64-Bit Server VM (build 23+37-2369, mixed mode, sharing)
11:22:23  + mkdir -p /home/jenkins/agent/workspace/eclipse.jdt.core-Github_master/tmp

https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Github/job/master/384/timestamps/?time=HH:mm:ss&timeZone=GMT+2&appendLog&locale=en_US

@jukzi
Copy link
Contributor

jukzi commented Sep 26, 2024

master shows now 2 failing tests:

 org.eclipse.jdt.core.tests.compiler.regression.PatternMatching16Test.test019 - 17
 org.eclipse.jdt.core.tests.builder.BuildpathTests.testChangeZIPArchive1

"testChangeZIPArchive1" already failed in this PR with java 21, so it is unrelated.
I don't see a issue reported for "PatternMatching16Test" yet. @mickaelistria would you mind to investigate?

@mickaelistria
Copy link
Contributor Author

I cannot reproduce this failure locally with java 23, running with PDE. I suspect that it could be a stream flush issue. Would it be possible to just re-run and see what happens?

@jukzi
Copy link
Contributor

jukzi commented Sep 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants